TivoWebPlus 2.1 Testing and Development

**kmt** · 06-22-2011, 12:01 PM

I just did the upgrade and the only problem I notice so far is with "info". I get most of the info but then

-------INTERNAL SERVER ERROR------ --cut here--NONE
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_summary" line 5)
invoked from: "space_summary"
--cut here--
-------INTERNAL SERVER ERROR------ --cut here--action:info, path:, env:, code:'NONE'
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_details" line 3)
invoked from: "space_details"
(procedure "info_Space" line 9)
invoked from: "info_$p $chan"
(procedure "MOD::action_info" line 4)
invoked from: "$cmd $chan $path $env"
--cut here--

**ktoyax** · 06-23-2011, 11:05 AM

Originally Posted by djl

Just want to publicly thank John for the new bundle, that must have taken a while. I'll echo what he said, if there's a problem with any of these changes post it here (someone will take a look).

I want to second djl's thanks to John. I, for one, certainly have appreciated all the effort everyone has put in over the years to keep this forum going.

Originally Posted by djl

It's great that there is some renewed interest in Tivoweb, so post whatever you come up with. I think including all seven categories makes sense; I don't remember why I didn't in the first place...

I have finished rolling John's bundle into my code, which includes restoring djl's # of # episode number code (my apologies for not having included it in the first place :-) ). Also, per djl's gracious suggestion, I have left my slightly expanded 7-type version of his code for the "Not an Episode" modification in rec.itcl.

I have added 2 new fields: start padding and end padding. I have also expanded the duplicate genres logic and have documented how the logic works.

I have reposted the Code for the TWP field and formatting changes back in the original post here. I have also updated the Now_Playing.jpg and Functions_and_Formats.jpg files to reflect the field and logic changes.

**djl** · 06-23-2011, 03:27 PM

Did you install the new bundle on top of the old? Just for a goof, go to channel prefs and reindex (helps with other modules), then do a full restart. If that doesn't help, list your tivo model and software version in your next post.

Originally Posted by kmt

I just did the upgrade and the only problem I notice so far is with "info". I get most of the info but then

-------INTERNAL SERVER ERROR------ --cut here--NONE
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_summary" line 5)
invoked from: "space_summary"
--cut here--
-------INTERNAL SERVER ERROR------ --cut here--action:info, path:, env:, code:'NONE'
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_details" line 3)
invoked from: "space_details"
(procedure "info_Space" line 9)
invoked from: "info_$p $chan"
(procedure "MOD::action_info" line 4)
invoked from: "$cmd $chan $path $env"
--cut here--

**mrdizzy** · 06-28-2011, 02:27 PM

Originally Posted by ktoyax

I want to second djl's thanks to John. I, for one, certainly have appreciated all the effort everyone has put in over the years to keep this forum going.

Thirded! That's certainly saved a huge amount of hunting around for patches.

I was a bit deflated though as I've got a problem with the chanpref.itcl module (got a bit confused here, as it channelprefs.itcl both create files containing the same line "Save file created by ChanPrefsTWP module."). Because it only saves channel numbers in the file, without callsigns as well, it means that when they are restored channels in both lineups are "selected" on a dual lineup TiVo.

Eg I have (UK S1 satellite and radio lineups)
101 BBC1 (from first lineup)
101 RADIO1 (from second lineup)

Even if I only have one of those selected, when a save file is restored, they are both ticked, because they are both "101". Repeat for a few hundred channels, sometime I want both, sometimes I want only the one in the 2nd lineup, or the first.

Of the 4 possible situations it only works where they are both unticked, as they are then not included in the save file.

I think the only way to fix this is to store both callsign and number in the file, because there are other BBC1's (the exact same Station) on other channel numbers in the lineup, and I only want the one that's on channel 101. Switching to storing callsigns instead in the file wouldn't work.

Has anyone had a go at fixing this please, that I might not have found yet?

**spitfires** · 07-20-2011, 04:41 AM

Love those customisable menus and row layouts but I can't be the only who's noticed that when it's generating programme screens 2.1.b3 runs as fast as a slug. A drunk slug. A drunk slug in a puddle of treacle.

It finally got the better of me so I spent some time timing the code and found the offending section which was slowing things waaaaay down.

Turns out the problem is a piece of code in index.itcl which appears to have been put in during testing of CVS 1.40.2.7

This does a binary scan for each and every channel on each and every line in the display. I.e. it is not using the cached data!

In tests I found the following speed improvement (on a UK S1)
- 126 rows generated in 20 secs (vs 85 secs currently)
- 329 rows generated in 68 secs (vs 276 secs currently)

That's a 400% speed improvement! I've been running this change for some weeks now and haven't had any adverse effects.

CVS browsing on sourceforge doesn't seem to be working but here's the link I used to diff the changelog
http://tivowebplus.cvs.sourceforge.n....6&r2=1.40.2.7

The change is to replace getStationData() in index.itcl with the following

Code:

proc getStationData { chinfo_var fsid {trans 1}} {
  upvar $chinfo_var chinfo
  if [info exists ::channelData($fsid)] {
    set bdata $::channelData($fsid)
  } else {

       if {(![info exists chinfo(fsid)]) || $fsid!=$chinfo(fsid)} {
       # puts "retrieving $fsid"	
       if {![findChannel chinfo $fsid 12]} { return 0 }
       set chinfo(num) [ReadableChannelNum $chinfo(numbin)]
       #~ puts num=$chinfo(num)
    }
	
    set rcv [expr $chinfo(bits) & 2]
    if {$trans} { RetryTransaction {
      set bdata [loadStationData $fsid $chinfo(chansub) $rcv]
    }} else {
      set bdata [loadStationData $fsid $chinfo(chansub) $rcv]
    }
    if {[string length $bdata]==0} { return 0 }
    set ::channelData($fsid) $bdata
    #logit rcv
  }
	
  #puts --[string length $bdata]
  binary scan $bdata IIaa* numbin logoindex rcv ids
  #if {$rcv!=2} {puts " !rcv: $fsid, [string index $::channelData($fsid) 8]"}
  set x [split $ids |]
  set chinfo(sign) [lindex $x 0]
  set chinfo(name) [lindex $x 1]
  set chinfo(logo) $logoindex
  set chinfo(stanum) [ReadableChannelNum $numbin]
	
  return 1
}

**ktoyax** · 07-21-2011, 02:48 AM

Originally Posted by spitfires

That's a 400% speed improvement! I've been running this change for some weeks now and haven't had any adverse effects.

Works great. Thanks!

**kmt** · 07-21-2011, 09:51 AM

Originally Posted by djl

Did you install the new bundle on top of the old? Just for a goof, go to channel prefs and reindex (helps with other modules), then do a full restart. If that doesn't help, list your tivo model and software version in your next post.

This refers to message 1068 which was a reply to 1066.

Yes, I installed the new bundle on top of the old using the "update" feature.

I tried the reindex and did a full restart with no effect.

My Tivo model is "United States TiVoHD Stand-Alone"

The Tivo software version is "11.0k-01-2-652"

Info says "Version 2.1.b3 (oztivo-110622" is the tivoweb version

Everything works except for the error messages I posted in 1066 as part of the "info" page.

**RandC** · 08-17-2011, 08:52 PM

running Version 2.1.b3 (oztivo-110622)
when using the folders module when I select a program(s) to be deleted, when it goes to the delete screen no programs are displayed.

Stopped and restarted TWP with the same results.

**jkozee** · 08-19-2011, 06:21 PM

How much total space do you have. Maybe I used a 32bit int when I should have used a 64bit int somewhere.

Originally Posted by kmt

I just did the upgrade and the only problem I notice so far is with "info". I get most of the info but then

-------INTERNAL SERVER ERROR------ --cut here--NONE
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_summary" line 5)
invoked from: "space_summary"
--cut here--
-------INTERNAL SERVER ERROR------ --cut here--action:info, path:, env:, code:'NONE'
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_details" line 3)
invoked from: "space_details"
(procedure "info_Space" line 9)
invoked from: "info_$p $chan"
(procedure "MOD::action_info" line 4)
invoked from: "$cmd $chan $path $env"
--cut here--

**spitfires** · 08-23-2011, 05:11 AM

Let's fix the annoying bug which displays the erroneous

-------INTERNAL SERVER ERROR------ --cut here--
can't read "x": no such variable

message instead of the proper error message.

Replace logit{} in btutils.itcl with this one

Code:

# [spitfires Aug 2011] Fix a bug in logit which prevents the error being displayed on the screen (you get "can't read "x": no such variable" instead of the correct error message!
#
proc logit args {
  #~ set s ""
  set nfo [info level -1]
  if {[lindex $args 0]==0} {
    set nfo [lindex $nfo 0]
    set args [lrange $args 1 end]
  }
  set out {}
  foreach arg $args {
    catch {
    upvar 1 $arg x
    if [array exists x] {lappend out "$arg=[array get x]"} else { if [info exists x] {lappend out "$arg=$x"} }
    }
  }
  set out "-($nfo)--([join $out ", "])"
  puts $out
  return $out
}

**spitfires** · 08-23-2011, 06:24 AM

Originally Posted by ktoyax

I have added several new fields and enabled formatting for all windows affected by the UI/RowFormat page.

Note that these changes have only been tested on a TivoHD. [snip sensible advice]

Cool changes thanks. Very pretty.. err I mean "useful"

However you should note that the -nocase option to "string match" isn't available on Series 1s. (Yes they're still used - it's all a lot of us have in the UK!

). So I've changed your string matching to use regexp.

**jkozee** · 08-23-2011, 04:36 PM

Looks like this is coming from reading a signed int instead of an unsigned int. Change the following line in get_space_tcl from:

Code:

set devSectors($devCnt) [expr $sec & ~(1023)]

to

Code:

set devSectors($devCnt) [expr $sec & ~(1023) & 0xffffffff]

Originally Posted by kmt

I just did the upgrade and the only problem I notice so far is with "info". I get most of the info but then

-------INTERNAL SERVER ERROR------ --cut here--NONE
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_summary" line 5)
invoked from: "space_summary"
--cut here--
-------INTERNAL SERVER ERROR------ --cut here--action:info, path:, env:, code:'NONE'
can't read "fdDevs(5)": no such element in array
while executing
"seek $fdDevs($x) [expr 512*$pZone+92]"
(procedure "get_space_tcl" line 33)
invoked from: "get_space_tcl"
(procedure "space_details" line 3)
invoked from: "space_details"
(procedure "info_Space" line 9)
invoked from: "info_$p $chan"
(procedure "MOD::action_info" line 4)
invoked from: "$cmd $chan $path $env"
--cut here--

**spitfires** · 08-26-2011, 06:43 AM

Blocklists were pretty much sidelined in TWP 2.1. This module puts them back in again and properly integrates them with the new rowformat layout.

1) Copy the files to your TiVo and do a "Quick" restart.

/libs/rec.itcl
/modules/blocklist.itcl
/modules/rowformat.itcl
/modules/ui_todo.itcl

2) Edit the ToDo layout using "RowFormat" and add

Code:

^`BLhead`^`BL`

where you want the column to appear.

Discussion: http://www.tivocommunity.com/tivo-vb...d.php?t=474868

**kmt** · 09-25-2011, 01:49 PM

The add season pass feature works except for actually causing the TODO to be recomputed. Is there any way to force it to do so without manually making a change to the passes order directly on the Tivo?

**Soapm** · 10-06-2011, 12:11 AM

I can't get TWP to run.

At the bash I type:

FamRoom2-bash# /TivoWebPlus/tivoweb &

And get:

FamRoom2-bash# Warning: An http server was already running

How can I tell what this server is that's running? I do a ps ax and don't see anything except gotomydvr. Could that be causing the problem?

and this is what I get with netstat:

FamRoom2-bash# netstat
Active Internet connections (w/o servers)
Proto Recv-Q Send-Q Local Address Foreign Address State
tcp 0 120 192.168.254.113:telnet 192.168.254.114:2042 ESTABLISHED
tcp 0 0 192.168.254.113:ftp 192.168.254.114:2834 CLOSE_WAIT
tcp 0 0 192.168.254.113:ftp 192.168.254.114:2826 CLOSE_WAIT
tcp 0 0 192.168.254.113:ftp 192.168.254.114:2883 CLOSE_WAIT
tcp 0 0 192.168.254.113:ftp 192.168.254.114:3124 CLOSE_WAIT
tcp 0 0 192.168.254.113:ftp 192.168.254.114:3719 CLOSE_WAIT
tcp 0 0 192.168.254.113:32771 tivochat1.tivo.com:5223 ESTABLISHED
tcp 0 0 192.168.254.113:ftp 192.168.254.114:3923 CLOSE_WAIT
tcp 0 0 192.168.254.113:ftp 192.168.254.114:4075 ESTABLISHED
tcp 0 0 192.168.254.113:ftp 192.168.254.114:4615 ESTABLISHED
Active UNIX domain sockets (w/o servers)
Proto RefCnt Flags Type State I-Node Path
unix 3 [ ] STREAM CONNECTED 6194 /var/dev/log
unix 3 [ ] STREAM CONNECTED 6193
unix 3 [ ] STREAM CONNECTED 1483 /var/dev/log
unix 3 [ ] STREAM CONNECTED 1482
unix 3 [ ] STREAM CONNECTED 1469 /var/dev/log
unix 3 [ ] STREAM CONNECTED 1468
unix 3 [ ] STREAM CONNECTED 1338 /var/dev/log
unix 3 [ ] STREAM CONNECTED 1337
unix 3 [ ] STREAM CONNECTED 1307 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 1331
unix 3 [ ] STREAM CONNECTED 1283 /var/dev/log
unix 3 [ ] STREAM CONNECTED 1282
unix 3 [ ] STREAM CONNECTED 1245 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 1276
unix 3 [ ] STREAM CONNECTED 1251 /var/dev/log
unix 3 [ ] STREAM CONNECTED 1250
unix 3 [ ] STREAM CONNECTED 787 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 1244
unix 3 [ ] STREAM CONNECTED 1142 /var/tmp/.podapp
unix 3 [ ] STREAM CONNECTED 1141
unix 3 [ ] STREAM CONNECTED 940 /var/tmp/.nccpapp
unix 3 [ ] STREAM CONNECTED 939
unix 3 [ ] STREAM CONNECTED 793 /var/dev/log
unix 3 [ ] STREAM CONNECTED 792
unix 3 [ ] STREAM CONNECTED 741 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 786
unix 3 [ ] STREAM CONNECTED 750 /var/dev/log
unix 3 [ ] STREAM CONNECTED 749
unix 3 [ ] STREAM CONNECTED 715 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 740
unix 3 [ ] STREAM CONNECTED 721 /var/dev/log
unix 3 [ ] STREAM CONNECTED 720
unix 3 [ ] STREAM CONNECTED 689 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 714
unix 3 [ ] STREAM CONNECTED 696 /var/dev/log
unix 3 [ ] STREAM CONNECTED 695
unix 3 [ ] STREAM CONNECTED 645 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 688
unix 3 [ ] STREAM CONNECTED 651 /var/dev/log
unix 3 [ ] STREAM CONNECTED 650
unix 3 [ ] STREAM CONNECTED 619 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 644
unix 3 [ ] STREAM CONNECTED 625 /var/dev/log
unix 3 [ ] STREAM CONNECTED 624
unix 3 [ ] STREAM CONNECTED 559 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 618
unix 3 [ ] STREAM CONNECTED 565 /var/dev/log
unix 3 [ ] STREAM CONNECTED 564
unix 3 [ ] STREAM CONNECTED 531 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 558
unix 3 [ ] STREAM CONNECTED 537 /var/dev/log
unix 3 [ ] STREAM CONNECTED 536
unix 3 [ ] STREAM CONNECTED 377 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 530
unix 3 [ ] STREAM CONNECTED 341 /var/dev/log
unix 3 [ ] STREAM CONNECTED 340
unix 3 [ ] STREAM CONNECTED 316 /var/tmp/jaganmata
unix 3 [ ] STREAM CONNECTED 334
unix 3 [ ] STREAM CONNECTED 293 /var/dev/log
unix 3 [ ] STREAM CONNECTED 292
unix 3 [ ] STREAM CONNECTED 268 /var/dev/log
unix 3 [ ] STREAM CONNECTED 267
unix 3 [ ] STREAM CONNECTED 258 /var/dev/log
unix 3 [ ] STREAM CONNECTED 257
unix 3 [ ] STREAM CONNECTED 197 /var/dev/log
unix 3 [ ] STREAM CONNECTED 196
unix 3 [ ] STREAM CONNECTED 114 /var/dev/log
unix 3 [ ] STREAM CONNECTED 113
FamRoom2-bash#

Thread: TivoWebPlus 2.1 Testing and Development

Thread Tools

Rate This Thread

Display

chanpref.itcl module bug?

400% speed improvement!

folders.itcl bug?

New Blocklist module for TivoWebPlus 2.1

Season Passes

Posting Permissions