(Deprecated) TiVoWebPlus 1.0

[RUBiK]

Thanks for the reply.. I did see the code has changed but haven't debugged/changed it yet (the old fix was setting $tzoffset to 0, I think)

Originally Posted by falcontx

I tried to fix this... thought I had.. anyhow.. type this at your bash prompt and tell me exactly what you get..

echo "puts \"[clock seconds] / [exec date] / [clock scan [exec date]] / [exec date -u] / [clock scan [exec date -u]]\"" | tivosh

falcontx

Sure... anything to try to figure out what's wrong here on my machine:

[~/tivoweb-tcl][567]$ echo "puts \"[clock seconds] / \
[exec date] / [clock scan [exec date]] / [exec date -u] / \
[clock scan [exec date -u]]\"" | tivosh
1075171839 / Mon Jan 26 18:50:39 PST 2004 / 1075171839 / Tue Jan 27 02:50:39 UTC 2004 / 1075171840
[~/tivoweb-tcl][568]$ date;date -u
Mon Jan 26 18:52:19 PST 2004
Tue Jan 27 02:52:20 UTC 2004

EDIT: Adding "puts $chan [tr "" [td "tzoffset"][td "colspan=4" "$::tzoffset"]]" in info.itcl results in "tzoffset -28800" being displayed...

[falcontx]

Originally Posted by RUBiK

Thanks for the reply.. I did see the code has changed but haven't debugged/changed it yet (the old fix was setting $tzoffset to 0, I think)

Sure... anything to try to figure out what's wrong here on my machine:

EDIT: Adding "puts $chan [tr "" [td "tzoffset"][td "colspan=4" "$::tzoffset"]]" in info.itcl results in "tzoffset -28800" being displayed...

Alright. I have it figured out now. It will be fixed in the next release. If you want to try out my fix, replace line 712 of httpd-tt.tcl with the following:

set tzoffset [expr round(([clock scan [lreplace [exec date -u] 4 4]] - [clock seconds] + [get_tzoffset $setuptz $daylightsavings])/60.0)*60]

Be sure to stop and restart TWP after making this change.

falcontx

[RUBiK]

Originally Posted by falcontx

Alright. I have it figured out now. It will be fixed in the next release. If you want to try out my fix, replace line 712 of httpd-tt.tcl with the following:

set tzoffset [expr round(([clock scan [lreplace [exec date -u] 4 4]] - [clock seconds] + [get_tzoffset $setuptz $daylightsavings])/60.0)*60]

Perfect. $tzoffset shows '0' now, which is "right". All the times are now displayed correctly.

Thanks much! Appreciate it.

[tommyw]

Originally Posted by falcontx

I agree. Aside from that, being in the release candidate phase of development, now is not the time to be adding new features. Our focus is currently on removing all remaining bugs so that we can have a stable, reliable final release.

falcontx

Are you interested in standardising the indentation, or is that going to be a different step?


Here's a good (or bad example:

proc SaveNames { namestr } {

  regsub -all { } $namestr "_" namestr
  if { [regexp {(.*),(.*)} $namestr] } {
    regsub -all {,_} $namestr " " namestr
    if { [regexp {(.*)[;:](.*)} $namestr] } {
    if { [regexp {(.*);(.*)} $namestr] } {
        regsub -all {;_} $namestr " " namestr
    }
    if { [regexp {(.*):(.*)} $namestr] } {
        regsub -all {:_} $namestr " " namestr
    }
    }

[falcontx]

Originally Posted by tommyw

Are you interested in standardising the indentation, or is that going to be a different step?

I've been doing it as I go, to some extent. Functionality and reliability are more important than how the code looks as far as I'm concerned, but if I notice something really screwed up, I'll usually go ahead and "fix" it.

falcontx

[tommyw]

Originally Posted by falcontx

I've been doing it as I go, to some extent. Functionality and reliability are more important than how the code looks as far as I'm concerned, but if I notice something really screwed up, I'll usually go ahead and "fix" it.

falcontx

Ah. You're not using emacs I take it?

Do you want me to reindent all the rc2 code, and ship you an archive then?

It's relatively easy to do, and has found me some bugs in some of the modules I've downloaded previously, as the brackets didn't all match!

Of course, your code base may well have changed since you made rc2 available...

[falcontx]

Originally Posted by tommyw

Ah. You're not using emacs I take it?

Do you want me to reindent all the rc2 code, and ship you an archive then?

It's relatively easy to do, and has found me some bugs in some of the modules I've downloaded previously, as the brackets didn't all match!

Of course, your code base may well have changed since you made rc2 available...

You're welcome to if you'd like. I'd recommend waiting for rc3 and then doing it asap so we can get it back from you before we need to make any more changes. When I've been doing it, I've been using two spaces to indent (as opposed to tabs). I'm not sure how other people do it, or if it even matters, but I thought I'd let you know.

falcontx

[TheWickedPriest]

The main thing is to be consistent -- pick a style and stick with it; it doesn't matter what style, as long as it's reasonably legible. And everyone on the project should adhere to the chosen style.

I don't know what the fashions are in TCL, but in my own C code, I like to use the equivalent of "indent -kr -i8", with the added rule that no line should be over 80 characters. (To that end, I sometimes use four-space intervals, or even smaller, instead of tabs.) Other people have different ideas.

[sublime]

First off: TivoWebPlus ROCKS my world, thank you thank you whomever worked on this fantastic piece.

Sometimes it locks up, and attempting to kill my TivoWebPlus process reboots my box.

Box is HDVR2

I do a ps -ax to find the PID of my TivoWebPlus:

140 ? S 7:08 tivosh /usr/tivoweb-tcl/httpd-tt.tcl

Then do a kill 140

It reboots my machine every time.

Any ideas?

[jonbig]

Originally Posted by sublime

I do a ps -ax to find the PID of my TivoWebPlus:

140 ? S 7:08 tivosh /usr/tivoweb-tcl/httpd-tt.tcl

Then do a kill 140

It reboots my machine every time.

Any ideas?

Tivos are set up to reboot automatically if a background process dies abnormally (including the use of kill). There's not much that can be done about it.

The more interesting question is why the httpd locks up in the first place. Are you sure you are being patient enough?

[splitsec]

Well, killing ANY process that is running under tivosh will reboot your box. Period end of story.

The only time I have had TivoWeb and/or TivoWebPlus lock up, is when my entire tivo locks up (ie. it won't take commands from the remote control either). It plays what ever it happened to be doing at the time just fine, but won't take any input. Generally I reboot at that point.

Split

Originally Posted by sublime

I do a ps -ax to find the PID of my TivoWebPlus:

140 ? S 7:08 tivosh /usr/tivoweb-tcl/httpd-tt.tcl

Then do a kill 140

It reboots my machine every time.

[Sleeper]

Originally Posted by sublime

Box is HDVR2

Are you by chance running 4.x software?

[sublime]

Originally Posted by Sleeper

Are you by chance running 4.x software?

Ah thanks for the input folks,

I had a feeling it had to do with the tivosh...

Sleeper, No I am not running 4.x, I am running your ISO (thanks) on my HDVR2 with a few minor modifications.

At times I have noticed the TivoWebPlus server does require a few minutes to catch up, then it comes back to life. Other times it has not come back for 20+ minutes. In that case I just force a reboot. If it occurs again, 'll try to dig deeper on which specific command it does not like.

[tivomaster]

Originally Posted by sublime

Ah thanks for the input folks,

I had a feeling it had to do with the tivosh...

Sleeper, No I am not running 4.x, I am running your ISO (thanks) on my HDVR2 with a few minor modifications.

At times I have noticed the TivoWebPlus server does require a few minutes to catch up, then it comes back to life. Other times it has not come back for 20+ minutes. In that case I just force a reboot. If it occurs again, 'll try to dig deeper on which specific command it does not like.

Have you been using the webremote tool? I have found with my HDVR2 if I do it causes the TiVo to lock up and eventually reboot. I stop using the webremote and it stays up for weeks.

[malfunct]

Originally Posted by tivomaster

Have you been using the webremote tool? I have found with my HDVR2 if I do it causes the TiVo to lock up and eventually reboot. I stop using the webremote and it stays up for weeks.

I found the same thing, though I quit using tivoweb when I figured out that it locked things up.